Handle all (most) JsonValue primitive types in the message template renderer - #9
Merged
KodrAus merged 1 commit intoSep 3, 2026
Conversation
…enderer, avoiding footguns when constructing JsonObjects programmatically. Assisted-by: Claude:claude-fable-5-1
KodrAus
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
JsonObjectevent documents are constructed programmatically (including through expressions), property values may be backed by a range of CLR value types. These are already handled when producing Seq.Syntax template output, but the embedded messagetemplates.org template renderer should handle them, too.